feat: extract commands::services from dashboard scan#76
Merged
Conversation
Lift the dashboard scan tree into a rendering-agnostic lib module so the axum dashboard and a future TUI consume the same services. The one binary-crate coupling (watched_locations) is injected into build_view. commands::view unchanged. No behavioral change to the dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
Lift the dashboard scan tree (
src/cli/dashboard/scan/) verbatim into a rendering-agnostic lib modulecommands::services, so the axum dashboard and a future ratatui TUI consume the same services layer. The single binary-crate coupling (watched_locations) is injected intobuild_viewrather than reached throughcrate::cli.commands::viewis unchanged; no behavioral change to the dashboard.Test plan
🤖 Generated with Claude Code